Remove node validate script (v3) #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages Signed-off-by: 1000TurquoisePogs <[email protected]>
Martin-Zeithaml
approved these changes
Nov 5, 2024
|
PR build fails due Marist connectivity issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app-server has a validate script which detects if node exists or not.
This is duplicate work from what zwe already does here https://github.com/zowe/zowe-install-packaging/blob/6abe8e9c3b80486c9d7f75a60f21b55cfa5ae2b2/bin/commands/internal/start/prepare/index.ts#L448-L451
When app-server runs validate, it leaves confusing messages behind
"FSUM7422 node is not found"
"Node found in NODE_HOME"
By removing validate and letting the zwe do its existing logic, no functionality is lost but the misleading messages are removed.